Making website logo clickable. #123
Conversation
…ill be land on the homepage of the website.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Hi @Narendra9906 |
client/src/components/logo/logo.tsx
Outdated
| </Typography> | ||
| </Typography> | ||
| </a> | ||
|
|
There was a problem hiding this comment.
Okay, @omrajsharma. Could you also tell me how to fix this? I added an tag (i.e., anchor element) inside the element. I set the path of the tag to https://www.bigohhh.com/. Could you please guide me? This is my first time contributing. I am newbies.
I removed the space. Please check it. If it’s okay, then I will have to send you another pull request.
import React, { FC } from 'react'
import { Box, Typography } from '@mui/material'
interface Props {
onClick?: () => void
variant?: 'primary' | 'secondary'
}
const Logo: FC = ({ variant }) => {
return (
<a href="https://www.bigohhh.com/" style={{ textDecoration: 'none' }}>
<Typography
variant="h4"
component="h1"
sx={{ fontWeight: 700, '& span': { color: variant === 'primary' ? 'primary.main' : 'unset' } }}
>
BigOhhh
)
}
Logo.defaultProps = {
variant: 'primary',
}
export default Logo
Pull Request Details #73
Description
Making website logo clickable. Whenever user click on the logo they will be land on the Home page of the website.
[Provide a brief overview of the changes introduced by this pull request.]
In this update, the functionality of the website logo has been enhanced to improve user navigation.
The changes were made in logo component. Inside logo.tsx file the Topography component, which renders the logo, has been wrapped in the anchor tag. The href attribute of the anchor tag has been set to "https://www.bigohhh.com/", which is the url of the homepage. This means when user clicks on the logo they will be redirected to the hompage.
Please note that the onCLick prop as its related to inrtergace declaration have been removed from the Logo component as they are no longer needed. This is a non-breaking chnages as it adds functionality in a backwards-compatible manner, as it does not affect any existing behaviour of the Logo Component.
Fixes
[Cite any related issues or bugs that this PR addresses, e.g., "Fixes #123"]
Type of PR
Screenshots (if applicable)
[If your changes include UI updates, provide screenshots to illustrate the changes.]
Additional Notes
[Include any additional information or context that might be helpful for reviewers.]
Checklist